Constant name for the app-boot.jar in app module #989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lanwen
changed the title
lanwen
changed the title
bsideup
approved these changes
Jul 27, 2021
bsideup
reviewed
Jul 27, 2021
Co-authored-by: Sergei Egorov <bsideup@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On jitpack version got added into jar file produced by the app module - so that it looks like
app-0.10.1-rc1-boot.jar.Obviously, tck during the search of the resource
app-boot.jarfails to find anything with a NPE,what makes tck app runner unusable outside of the original repo. Also currently, all jars embedded into tck,
however we need only a boot one (among sources and bare minimum ones), so this PR fixes that as well.