Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverse loosening of priority constraints in regex & tests #182

Closed
6 tasks done
bskinn opened this issue Feb 4, 2021 · 0 comments · Fixed by #189
Closed
6 tasks done

Reverse loosening of priority constraints in regex & tests #182

bskinn opened this issue Feb 4, 2021 · 0 comments · Fixed by #189
Milestone

Comments

@bskinn
Copy link
Owner

bskinn commented Feb 4, 2021

Per discussion at #181, Sphinx will silently ignore object entries with non-integer priority values

  • Code
  • Tests
    • Remove objects.inv files with non-integer priority from main tests
    • Establish consistent nomenclature to identify objects.inv with non-integer priority and add fails-to-load tests for them
      • More complicated than necessary. With the new custom-built data line testing, it was easy to put invalid priority cases in.
  • Docs
  • CHANGELOG
@bskinn bskinn added this to the v2.1 milestone Feb 4, 2021
bskinn added a commit that referenced this issue Feb 5, 2021
Part of #182, these inventories will now never be valid,
barring a change to how Sphinx handles the priority values.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant