Allow API key to be set, in case redirection fails #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BitcoinMitchell
changed the title
BitcoinMitchell
force-pushed
the
5.x-use-api-key-in-form
branch
4 times, most recently
from
cc873f0 to
342078b
Compare
BitcoinMitchell
changed the title
BitcoinMitchell
force-pushed
the
5.x-use-api-key-in-form
branch
4 times, most recently
from
03cc155 to
4580840
Compare
BitcoinMitchell
changed the title
BitcoinMitchell
force-pushed
the
5.x-use-api-key-in-form
branch
5 times, most recently
from
360eb73 to
84387d5
Compare
BitcoinMitchell
force-pushed
the
5.x-use-api-key-in-form
branch
from
84387d5 to
d1f34d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible solution for the
Invalid token: direct access to this link may lead to a potential security breach-issues. The pop-up sometimes appears and sometimes it doesn't and it has been near impossible to debug why.One reason I did find is because
PrestaShopassumes thatPOST-requests from BTCPay Server are evil (even though I use a valid token) and I have no way to bypass/resolve it. I did see that routes withapi_in the name should be skipped, but that triggers something else that logs you out fully, which is not great.You can disable the tokens store-wide, but that just feels like a terrible idea, so I've gone back to what we used to do in this plugin, just ask for the API key and display a URL where you can create it with all required permissions.
This setup is not perfect, but it works: btcpay v5.2.0.zip.
This will require a documentation change in https://github.com/btcpayserver/btcpayserver-doc/edit/master/docs/PrestaShop.md