-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce order protection + Improved processing of the webhook #96
Conversation
73daf8f
to
067d628
Compare
ef1f321
to
ca6bd8f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work and refactor, much cleaner and nice feature of the order protection 👍
Only a few nitpicks, feel free to ignore.
Thank you, I'll create PRs for the the nitpicks that I will merge into this PR, before I merge this entire PR into master. I've noticed that maybe we are adding too many messages, will rethink that as well. |
6a2ec45
to
ae49901
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested several use cases, partial payments, manually settled/invalid, expired, overpayment
Looks all good and with nice warning in case of unusual flow e.g. manually setting paid and then getting an expired / manually marked invalid webhook
Nice work 👍
Awesome, glad to hear it all worked smoothly. The only thing I wanna double check now is different currencies (since I do |
Only accepts the commands you really need
Enabled by default
ae49901
to
602787e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
- Added payment to order for settled payments.
- Improved overall processing of an order.
- DX: Adds a simple
bitcoin-cli.sh
-script to interact with thebitcoind
defined in the docker-compose.- #95
- For every settled payment, a payment should be added to the order.
- Re-triggering an
InvoicePaymentSettled
-webhook should not add an additional payment.