txscript: reduce allocations from sigop count #1380
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a countOnly flag to parseScriptTemplate, which will compute the number of sigops in the script, without allocating a slice for parsedOpcodes or slicing data from the script. If an error is returned during parsing, the number of sigops up to that point is returned. This mimics the existing behavior where the parsed opcodes would be returned up to the point of faliure, from which the sigop count is then derived. This reduces the need for large, single-use memory allocations when computing sigop counts, which otherwise increases the gc overhead during block validation.
Adds a isScriptHashScript which determines if a given script is a script hash. This is used to avoid parsing the opcodes when computing the precise opcode count for non-bip16 p2sh outputs, and allows us to use the more efficient zero-alloc sigop count.
This commit adds a helper method performing zero-alloc sigop counts. We build on the prior changes by now parsing the script in countOnly mode, and returning the number of sigs. The helper is then used in various places where the parse opcodes were simply discarded after getting the sigop count.
|
@jcvernaleo (as per #1530)
|
|
@cfromknecht do we have any gobench's related to this method? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.