Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump btcd version in btcutil package #1866

Merged
merged 4 commits into from
Aug 11, 2022

Conversation

darioush
Copy link
Contributor

@darioush darioush commented Jun 29, 2022

Hi,

When I depend on github.com/btcsuite/btcd/btcutil v1.1.1 (but not github.com/btcsuite/btcd), I end up with the
v0.22.0-beta.0.20220111032746-97732e52810c version as a dependency in my go.sum.

This would normally be fine but it seems you have recently fixed an ambiguous import issue (#1839):

github.com/btcsuite/btcd/chaincfg/chainhash: ambiguous import: found package github.com/btcsuite/btcd/chaincfg/chainhash in multiple modules:
	github.com/btcsuite/btcd v0.21.0-beta (/Users/darioush.jalali/go/pkg/mod/github.com/btcsuite/btcd@v0.21.0-beta/chaincfg/chainhash)
	github.com/btcsuite/btcd/chaincfg/chainhash v1.0.1 (/Users/darioush.jalali/go/pkg/mod/github.com/btcsuite/btcd/chaincfg/chainhash@v1.0.1)

So it would be beneficial to bump the version in the sub-module past your fix.
Apologies in advance if you would have preferred an issue instead of a PR. Thanks :)

@darioush
Copy link
Contributor Author

Also noticed #1825 may fix this.

btcutil/go.mod Show resolved Hide resolved
Copy link
Member

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💵

@coveralls
Copy link

coveralls commented Jul 14, 2022

Pull Request Test Coverage Report for Build 2593225086

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 17 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.04%) to 55.005%

Files with Coverage Reduction New Missed Lines %
connmgr/connmanager.go 2 86.07%
txscript/taproot.go 2 95.93%
peer/peer.go 13 73.2%
Totals Coverage Status
Change from base Build 2456385554: -0.04%
Covered Lines: 26435
Relevant Lines: 48059

💛 - Coveralls

@Roasbeef Roasbeef merged commit 0f49e10 into btcsuite:master Aug 11, 2022
@darioush darioush deleted the bump-btcutils-versions branch August 11, 2022 01:31
@coveralls
Copy link

coveralls commented Nov 30, 2024

Pull Request Test Coverage Report for Build 2653112605

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 18 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.04%) to 55.003%

Files with Coverage Reduction New Missed Lines %
btcutil/gcs/gcs.go 1 81.25%
connmgr/connmanager.go 2 86.07%
txscript/taproot.go 2 95.93%
peer/peer.go 13 73.2%
Totals Coverage Status
Change from base Build 2456385554: -0.04%
Covered Lines: 26434
Relevant Lines: 48059

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants