Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

btcutil/psbt: add method Packet.GetTxFee #1916

Merged
merged 1 commit into from
Nov 7, 2022
Merged

btcutil/psbt: add method Packet.GetTxFee #1916

merged 1 commit into from
Nov 7, 2022
+19 −2

Conversation

ffranr
Copy link
Contributor

@ffranr ffranr commented Nov 3, 2022

This commit adds a GetTxFee method to the psbt.Packet structure. The method returns the PSBT's fee.

@ffranr ffranr mentioned this pull request Nov 3, 2022
Merged
1 task
@coveralls
Copy link

coveralls commented Nov 3, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3394761498

  • 0 of 11 (0.0%) changed or added relevant lines in 1 file are covered.
  • 7 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-10.4%) to 62.874%
Changes Missing Coverage Covered Lines Changed/Added Lines %
btcutil/psbt/psbt.go 0 11 0.0%
Files with Coverage Reduction New Missed Lines %
mempool/mempool.go 1 66.75%
connmgr/connmanager.go 2 86.79%
peer/peer.go 4 73.2%
Totals Coverage Status
Change from base Build 3369294878: -10.4%
Covered Lines: 17606
Relevant Lines: 28002
💛 - Coveralls

@ffranr ffranr force-pushed the add_gettxfee branch 2 times, most recently from d0cea35 to 068f69c Compare November 3, 2022 20:54
guggero
guggero approved these changes Nov 4, 2022
View reviewed changes
Copy link
Collaborator

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM 🎉

btcutil/psbt/psbt.go Outdated Show resolved Hide resolved
btcutil/psbt/psbt.go Outdated Show resolved Hide resolved
@guggero
Copy link
Collaborator

guggero commented Nov 4, 2022

cc @positiveblue.

@ffranr
btcutil/psbt: add method Packet.GetTxFee
586729c 
This commit adds a GetTxFee method to the psbt.Packet structure. The method returns the PSBT's fee.
positiveblue
positiveblue approved these changes Nov 7, 2022
View reviewed changes
Copy link

@positiveblue positiveblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@guggero guggero merged commit 63835cb into btcsuite:master Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@positiveblue positiveblue positiveblue approved these changes

@guggero guggero guggero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ffranr @coveralls @guggero @positiveblue