Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix some comment #2080

Merged
merged 2 commits into from
Apr 10, 2024
Merged

fix some comment #2080

merged 2 commits into from
Apr 10, 2024

Conversation

zhiqiangxu
Copy link
Contributor

No description provided.

@zhiqiangxu zhiqiangxu changed the title Remove duplicate comment fix some comment Dec 28, 2023
guggero
guggero reviewed Jan 3, 2024
View reviewed changes
Copy link
Collaborator

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Can you please squash your commits into a single one and use a proper commit message?

mempool/mempool.go Outdated Show resolved Hide resolved
txscript/standard.go Show resolved Hide resolved
@zhiqiangxu
Copy link
Contributor Author

Thanks. Can you please squash your commits into a single one and use a proper commit message?

Done.

@guggero
Copy link
Collaborator

guggero commented Jan 3, 2024

Still two commits and the message should say what the commit changes, not what the developer did when creating the commit.

@zhiqiangxu
Copy link
Contributor Author

Still two commits and the message should say what the commit changes, not what the developer did when creating the commit.

Another squash is done:)

guggero
guggero approved these changes Jan 3, 2024
View reviewed changes
Copy link
Collaborator

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM 🎉

@coveralls
Copy link

coveralls commented Jan 3, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8433093311

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 2 files are covered.
  • 10 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.02%) to 56.868%
Files with Coverage Reduction New Missed Lines %
btcutil/gcs/gcs.go 1 81.25%
peer/peer.go 9 73.49%
Totals Coverage Status
Change from base Build 8433036656: -0.02%
Covered Lines: 29422
Relevant Lines: 51737
💛 - Coveralls

jcvernaleo
jcvernaleo approved these changes Apr 10, 2024
View reviewed changes
Copy link
Member

@jcvernaleo jcvernaleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@jcvernaleo jcvernaleo merged commit 2f4ff84 into btcsuite:master Apr 10, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guggero guggero guggero approved these changes

@jcvernaleo jcvernaleo jcvernaleo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zhiqiangxu @guggero @coveralls @jcvernaleo