Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

main, rpcclient, integration: add rpccalls for invalidate and reconsiderblock #2197

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

Crypt-iQ
Copy link
Collaborator

@Crypt-iQ Crypt-iQ commented Jun 7, 2024

Adds rpc calls for the invalidate and reconsiderblock methods on BlockChain.

Replaces #2183 and depends on #2196

@coveralls
Copy link

coveralls commented Jun 7, 2024

Pull Request Test Coverage Report for Build 9423884255

Details

  • 144 of 210 (68.57%) changed or added relevant lines in 3 files are covered.
  • 15 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.2%) to 57.237%

Changes Missing Coverage Covered Lines Changed/Added Lines %
rpcserver.go 0 26 0.0%
blockchain/chain.go 129 169 76.33%
Files with Coverage Reduction New Missed Lines %
blockchain/chain.go 3 74.78%
connmgr/connmanager.go 3 86.27%
peer/peer.go 9 74.08%
Totals Coverage Status
Change from base Build 9348961734: 0.2%
Covered Lines: 29797
Relevant Lines: 52059

💛 - Coveralls

@Roasbeef
Copy link
Member

Needs a rebase!

invalidateblock and reconsiderblock are added to the rpcclient package
and an integration test is added to test the added functions.
The rpc calls and the rpchelp is added for the invalidateblock
and reconsiderblock methods on BlockChain.
@coveralls
Copy link

coveralls commented Jun 20, 2024

Pull Request Test Coverage Report for Build 9589424465

Details

  • 15 of 41 (36.59%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 57.249%

Changes Missing Coverage Covered Lines Changed/Added Lines %
rpcserver.go 0 26 0.0%
Totals Coverage Status
Change from base Build 9589079505: 0.2%
Covered Lines: 29803
Relevant Lines: 52059

💛 - Coveralls

Copy link
Member

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚈

@Roasbeef Roasbeef merged commit 93e7291 into btcsuite:master Jun 20, 2024
3 checks passed
@Crypt-iQ Crypt-iQ deleted the 2183_eugene branch June 21, 2024 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants