Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpcserver: fix SignCompact #2213

Closed
wants to merge 1 commit into from

Conversation

yyforyongyu
Copy link
Collaborator

@yyforyongyu yyforyongyu commented Jul 15, 2024

Introduced in #2211, we need to update the rpcserver.go to use this method. In addition we need to tag a new version for btcec. We also need to update lnd when the version is tagged. Will update the relevant packages once it's tagged.

@yyforyongyu yyforyongyu marked this pull request as draft July 15, 2024 21:52
@Roasbeef
Copy link
Member

⛰   git push origin btcec/v2.3.4
Enumerating objects: 1, done.
Counting objects: 100% (1/1), done.
Writing objects: 100% (1/1), 1.38 KiB | 707.00 KiB/s, done.
Total 1 (delta 0), reused 0 (delta 0), pack-reused 0
To github.com:btcsuite/btcd.git
 * [new tag]             btcec/v2.3.4 -> btcec/v2.3.4
 * ```

@guggero
Copy link
Collaborator

guggero commented Jul 23, 2024

Oops, I didn't see there's already a PR for it... Created a new one here: #2218

@yyforyongyu
Copy link
Collaborator Author

Replaced by #2218

@yyforyongyu yyforyongyu deleted the fix-sign-compact branch July 23, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants