Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spendable field to listunspent result. #288

Merged
merged 1 commit into from
Jul 21, 2015

Conversation

jrick
Copy link
Member

@jrick jrick commented May 27, 2015

Fixes #262.

Requires btcsuite/btcd#440.

@jrick
Copy link
Member Author

jrick commented May 27, 2015

This isn't quite right yet. Bitcoin Core wallet will only mark multisig outputs as spendable ("mine") if all involved keys belong to the wallet.

@jrick jrick force-pushed the jrick_listunspent_spendable branch 2 times, most recently from 86062b3 to 74c38cd Compare May 27, 2015 21:33
@jrick
Copy link
Member Author

jrick commented May 28, 2015

I started to work on the watching only bits to check if the outputs are actually spendable, but without the WatchingOnly() bool method on the managed addresses it is incredibly painful (have to attempt to access the privkey/script just to compare the error to one particular error case, while working around several others). Even though the entire manager can be exported watching only, I don't think it's worth the effort since all of this code would be thrown out later anyways.

After #204 this will need to be updated with the new method.

@davecgh
Copy link
Member

davecgh commented Jul 21, 2015

Needs a squash and rebase, but OK after that.

@jrick jrick force-pushed the jrick_listunspent_spendable branch from ba72511 to eb25d88 Compare July 21, 2015 17:41
@conformal-deploy conformal-deploy merged commit eb25d88 into btcsuite:master Jul 21, 2015
@jrick jrick deleted the jrick_listunspent_spendable branch July 21, 2015 17:50
jrick added a commit to jrick/btcwallet that referenced this pull request Jun 30, 2016
buck54321 added a commit to buck54321/btcwallet that referenced this pull request May 8, 2024
Remove duplicate NeutrinoClient interface
Merge btcsuite#265 cache+neutrino: add new cache module by @Roasbeef
Merge btcsuite#261 cache+neutrino: update existing Cache interface to use type parameters by @Roasbeef
Merge btcsuite#268 cache: add deletion and iteration methods by @yyforyongyu
Merge btcsuite#279 lru: add methods to range with orders by @yyforyongyu
Merge btcsuite#278 pushtx: map different backend err to internal err by @ziggie1984
Merge btcsuite#273 query+neutrino: use query dispatcher for GetBlock and GetCFilte by @ellemouton
Merge btcsuite#274 multi: introduce a batch filter writer by @ellemouton
Merge btcsuite#275 rescan: use batch filter fetching by @ellemouton
Merge btcsuite#283 blockmanager.go: use btcd libs to validate headers by @guggero
Merge btcsuite#288 neutrino: Added ResetRanking method to PeerRanking by @Chinwendu20
Merge btcsuite#293 & btcsuite#294 Fix typos by @vuittont60
Merge btcsuite#297 query: fix retry query case by @ziggie1984
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

listunspent does not set spendable field
3 participants