bdb: specify freelist options by default #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the bbolt dependency to v1.3.3 so that we can use the NoFreelistSync option without triggering a panic in case a rollback occurs.
This commit specifies two bbolt options when opening the bbolt db. This reduces heap pressure in case there are a lot of pages on the freelist.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to lightningnetwork/lnd#3278
I did see a number of rollbacks occurring on initial startup, but I will need to see if I can recreate this. Under rollbacks, the freelist must be built again temporarily which is burdensome with large freelists. Will report back.
Edit: Should be fine to proceed with.