Use SLF4J SimpleLogger #562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is introducing SLF4J SimpleLogger as a replacement for a very sub-par BTrace logging implementation.
In addition to using a standard logging API the SimpleLogger also provides a few configuration knobs (https://www.slf4j.org/api/org/slf4j/impl/SimpleLogger.html).
The downside is that the logging level is shared amongst all the deployed probes and the loggers are not dynamically reconfigured. Given that such behaviour is already quite ill defined and not running with debug verbosity is mostly useful when debugging a particular problem this might turn out to be a non-problem.