Implement D-Bus portal backend #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
btzy
force-pushed
the
xdg-desktop-portal
branch
from
240b3fa
to
e7122f5
Compare
btzy
force-pushed
the
xdg-desktop-portal
branch
from
e7122f5
to
4063ab2
Compare
btzy
force-pushed
the
xdg-desktop-portal
branch
3 times, most recently
from
b08a8cd
to
7028e89
Compare
btzy
force-pushed
the
xdg-desktop-portal
branch
from
7028e89
to
ad9f5a2
Compare
btzy
force-pushed
the
xdg-desktop-portal
branch
3 times, most recently
from
8b63457
to
a946328
Compare
btzy
force-pushed
the
xdg-desktop-portal
branch
from
a946328
to
9afdccb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an alternative implementation for Linux, that uses xdg-desktop-portal so that the "native" file dialog is displayed. (In practice, this is either GTK or KDE; xfce doesn't have a portal backend implementation.) It makes D-Bus API calls directly. This should work if the user has xdg-desktop-portal and a suitable backend (either xdg-desktop-portal-gtk or xdg-desktop-portal-kde) installed (which apparently is the case for all common desktop Linux distributions), but will fail with NFD_ERROR otherwise.
This implementation links with D-Bus (dbus-1) instead of of GTK (gtk+-3.0).
Closes #24. Also refer to mlabbe/nativefiledialog#40.