Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kiai.js v1 #56

Merged
merged 8 commits into from
Jul 1, 2023
Merged

Kiai.js v1 #56

merged 8 commits into from
Jul 1, 2023

Conversation

thewilloftheshadow
Copy link
Member

No description provided.

@thewilloftheshadow thewilloftheshadow self-assigned this Apr 27, 2023
@changeset-bot
Copy link

changeset-bot bot commented Apr 27, 2023

🦋 Changeset detected

Latest commit: ccec12f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
kiai.js Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@socket-security
Copy link

socket-security bot commented Apr 27, 2023

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

@thewilloftheshadow thewilloftheshadow marked this pull request as ready for review June 10, 2023 13:45
@socket-security
Copy link

socket-security bot commented Jun 10, 2023

New and updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
eslint-config-turbo 1.9.3 eval +57 9.9 MB turbobot
eslint-config-prettier 8.8.0 eval +56 9.66 MB lydell
@typescript-eslint/eslint-plugin 5.59.1 eval +73 16 MB jameshenry
@typescript-eslint/parser 5.59.0 eval +62 11.5 MB jameshenry
eslint 8.38.0 eval, filesystem, environment +55 9.64 MB eslintbot
dotenv-cli 7.2.1 environment +3 114 kB entropitor
@buape/kiai-api-types 0.1.0...1.1.0 None +0/-0 32.7 kB thewilloftheshadow
node-fetch 3.3.0...3.3.1 None +0/-0 107 kB node-fetch-bot

Copy link
Contributor

@OIRNOIR OIRNOIR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not really sure if all of this is correct (this is a huge diff) but looking through the various features and stuff there doesn't seem to be anything I'd want to change

@thewilloftheshadow
Copy link
Member Author

That's fine, I'll go through and do full tests, as long as you like the structure

@OIRNOIR
Copy link
Contributor

OIRNOIR commented Jun 12, 2023

Yeah, the structure lgtm

@OIRNOIR
Copy link
Contributor

OIRNOIR commented Jun 12, 2023

But fix the failed build

@thewilloftheshadow thewilloftheshadow merged commit 700caf3 into main Jul 1, 2023
5 checks passed
@thewilloftheshadow thewilloftheshadow deleted the kiaijs-v1 branch July 1, 2023 18:33
@thewilloftheshadow thewilloftheshadow added the p: kiai.js This is for the kiai.js package label Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p: kiai.js This is for the kiai.js package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants