Use kotlin-test asserters #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebraminio
commented
Apr 6, 2022
| @@ -26,6 +27,6 @@ class SyncWorkerTest { | |||
| val workerBuilder = TestWorkerBuilder.from(targetContext, SyncWorker::class.java) | |||
| val worker = workerBuilder.build() | |||
| val result = worker.doWork() | |||
| Assert.assertTrue(result is ListenableWorker.Result.Retry) | |||
| assertIs<ListenableWorker.Result.Retry>(result) | |||
There was a problem hiding this comment.
Please note that this is already broken on master and this won't change that breakage.
As it provides more Kotlin idiomatic asserters than Java asserters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it provides more Kotlin idiomatic asserters than Java asserters.
assertIs<T>(value)instead having to writeassertTrue(value is T)assertContentEqualswhich works with iterables instead requiring arrays likeassertArrayEqualsassertFailsinstead currentassertThrows(Exception::class.java)which forces you to specify the type, there is aassertFailsWithalso when a type is needed.assertEqualscan be used insteadassertTrueand etc