fix: switch lazy loading images to eager #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 63.24% // Head: 63.24% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #359 +/- ##
=======================================
Coverage 63.24% 63.24%
=======================================
Files 10 10
Lines 555 555
Branches 129 129
=======================================
Hits 351 351
Misses 146 146
Partials 58 58
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
bubkoo
approved these changes
Jan 30, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Jan 30, 2023
## [1.11.5](v1.11.4...v1.11.5) (2023-01-30) ### Bug Fixes * **cloneCSSStyle:** rounded values of d attr fix ([#358](#358)) ([6d28bdb](6d28bdb)), closes [#357](#357) * include source in npm package ([#316](#316)) ([b609415](b609415)) * switch lazy loading images to eager ([#359](#359)) ([f7c311b](f7c311b))
|
🎉 This PR is included in version 1.11.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
istaiti
pushed a commit
to inscreen/html-to-image
that referenced
this pull request
Feb 7, 2023
istaiti
pushed a commit
to inscreen/html-to-image
that referenced
this pull request
Feb 7, 2023
## [1.11.5](bubkoo/html-to-image@v1.11.4...v1.11.5) (2023-01-30) ### Bug Fixes * **cloneCSSStyle:** rounded values of d attr fix ([bubkoo#358](bubkoo#358)) ([6d28bdb](bubkoo@6d28bdb)), closes [bubkoo#357](bubkoo#357) * include source in npm package ([bubkoo#316](bubkoo#316)) ([b609415](bubkoo@b609415)) * switch lazy loading images to eager ([bubkoo#359](bubkoo#359)) ([f7c311b](bubkoo@f7c311b))
istaiti
pushed a commit
to inscreen/html-to-image
that referenced
this pull request
Feb 7, 2023
istaiti
pushed a commit
to inscreen/html-to-image
that referenced
this pull request
Feb 7, 2023
## [1.11.5](bubkoo/html-to-image@v1.11.4...v1.11.5) (2023-01-30) ### Bug Fixes * **cloneCSSStyle:** rounded values of d attr fix ([bubkoo#358](bubkoo#358)) ([6d28bdb](bubkoo@6d28bdb)), closes [bubkoo#357](bubkoo#357) * include source in npm package ([bubkoo#316](bubkoo#316)) ([b609415](bubkoo@b609415)) * switch lazy loading images to eager ([bubkoo#359](bubkoo#359)) ([f7c311b](bubkoo@f7c311b))
istaiti
pushed a commit
to inscreen/html-to-image
that referenced
this pull request
Feb 7, 2023
istaiti
pushed a commit
to inscreen/html-to-image
that referenced
this pull request
Feb 7, 2023
## [1.11.5](bubkoo/html-to-image@v1.11.4...v1.11.5) (2023-01-30) ### Bug Fixes * **cloneCSSStyle:** rounded values of d attr fix ([bubkoo#358](bubkoo#358)) ([6d28bdb](bubkoo@6d28bdb)), closes [bubkoo#357](bubkoo#357) * include source in npm package ([bubkoo#316](bubkoo#316)) ([b609415](bubkoo@b609415)) * switch lazy loading images to eager ([bubkoo#359](bubkoo#359)) ([f7c311b](bubkoo@f7c311b))
istaiti
pushed a commit
to inscreen/html-to-image
that referenced
this pull request
Feb 7, 2023
istaiti
pushed a commit
to inscreen/html-to-image
that referenced
this pull request
Feb 7, 2023
## [1.11.5](bubkoo/html-to-image@v1.11.4...v1.11.5) (2023-01-30) ### Bug Fixes * **cloneCSSStyle:** rounded values of d attr fix ([bubkoo#358](bubkoo#358)) ([6d28bdb](bubkoo@6d28bdb)), closes [bubkoo#357](bubkoo#357) * include source in npm package ([bubkoo#316](bubkoo#316)) ([b609415](bubkoo@b609415)) * switch lazy loading images to eager ([bubkoo#359](bubkoo#359)) ([f7c311b](bubkoo@f7c311b))
istaiti
pushed a commit
to inscreen/html-to-image
that referenced
this pull request
Feb 7, 2023
istaiti
pushed a commit
to inscreen/html-to-image
that referenced
this pull request
Feb 7, 2023
## [1.11.5](bubkoo/html-to-image@v1.11.4...v1.11.5) (2023-01-30) ### Bug Fixes * **cloneCSSStyle:** rounded values of d attr fix ([bubkoo#358](bubkoo#358)) ([6d28bdb](bubkoo@6d28bdb)), closes [bubkoo#357](bubkoo#357) * include source in npm package ([bubkoo#316](bubkoo#316)) ([b609415](bubkoo@b609415)) * switch lazy loading images to eager ([bubkoo#359](bubkoo#359)) ([f7c311b](bubkoo@f7c311b))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed an issue with my images not loading. I traced it to neither
onloadoronerrorfiring during theembedImageNodestep, which I was able to fix by changing theloading(https://developer.mozilla.org/en-US/docs/Web/HTML/Element/img#attr-loading) attribute toeagerinstead oflazyas my images are.Description
Add a condition during
embedImageNodethat changes lazy loading images to eager to ensure (ideally) that onload/onerror fires.Motivation and Context
This problem occurs at least for me when I have an
imgwhich hasloading(https://developer.mozilla.org/en-US/docs/Web/HTML/Element/img#attr-loading) set tolazy. Changing this toeagerstops the problem, so I've made this adjustment occur during cloning as we would not want to lazy loading images when we are trying to clone them and are waiting for them to finish decoding/loading.Types of changes
Self Check before Merge