Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: include source in npm package #316

Merged
merged 1 commit into from
Jan 30, 2023
Merged

Conversation

jeanfrancois8512
Copy link
Contributor

Description

I added "src" in the files attribute of package.json

Motivation and Context

Types of changes

  • [x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Enhancement (changes that improvement of current feature or performance)
  • Refactoring (changes that neither fixes a bug nor adds a feature)
  • Test Case (changes that add missing tests or correct existing tests)
  • Code style optimization (changes that do not affect the meaning of the code)
  • Docs (changes that only update documentation)
  • [ x] Chore (changes that don't modify src or test files)

Self Check before Merge

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@biiibooo
Copy link
Contributor

biiibooo bot commented Sep 20, 2022

👋 @jeanfrancois8512

💖 Thanks for opening this pull request! 💖

Please follow the contributing guidelines. And we use semantic commit messages to streamline the release process.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add graph.scale() method
  • docs: graph.getShortestPath is now available

Things that will help get your PR across the finish line:

  • Follow the TypeScript coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@codecov
Copy link

codecov bot commented Sep 20, 2022

Codecov Report

Base: 67.05% // Head: 67.05% // No change to project coverage 👍

Coverage data is based on head (009dcac) compared to base (471ad8d).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #316   +/-   ##
=======================================
  Coverage   67.05%   67.05%           
=======================================
  Files          10       10           
  Lines         513      513           
  Branches      119      119           
=======================================
  Hits          344      344           
  Misses        120      120           
  Partials       49       49           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Frimko
Copy link

Frimko commented Jan 27, 2023

@bubkoo we need this PR plz. by #257

@bubkoo bubkoo merged commit b609415 into bubkoo:master Jan 30, 2023
@biiibooo
Copy link
Contributor

biiibooo bot commented Jan 30, 2023

👋 @jeanfrancois8512 Congrats on merging your first pull request! 🎉🎉🎉

@Frimko
Copy link

Frimko commented Jan 30, 2023

@bubkoo and new npm-version plz.

github-actions bot pushed a commit that referenced this pull request Jan 30, 2023
## [1.11.5](v1.11.4...v1.11.5) (2023-01-30)

### Bug Fixes

* **cloneCSSStyle:** rounded values of d attr fix ([#358](#358)) ([6d28bdb](6d28bdb)), closes [#357](#357)
* include source in npm package ([#316](#316)) ([b609415](b609415))
* switch lazy loading images to eager ([#359](#359)) ([f7c311b](f7c311b))
@biiibooo
Copy link
Contributor

biiibooo bot commented Jan 30, 2023

🎉 This PR is included in version 1.11.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@biiibooo biiibooo bot added the released label Jan 30, 2023
istaiti pushed a commit to inscreen/html-to-image that referenced this pull request Feb 7, 2023
istaiti pushed a commit to inscreen/html-to-image that referenced this pull request Feb 7, 2023
## [1.11.5](bubkoo/html-to-image@v1.11.4...v1.11.5) (2023-01-30)

### Bug Fixes

* **cloneCSSStyle:** rounded values of d attr fix ([bubkoo#358](bubkoo#358)) ([6d28bdb](bubkoo@6d28bdb)), closes [bubkoo#357](bubkoo#357)
* include source in npm package ([bubkoo#316](bubkoo#316)) ([b609415](bubkoo@b609415))
* switch lazy loading images to eager ([bubkoo#359](bubkoo#359)) ([f7c311b](bubkoo@f7c311b))
istaiti pushed a commit to inscreen/html-to-image that referenced this pull request Feb 7, 2023
istaiti pushed a commit to inscreen/html-to-image that referenced this pull request Feb 7, 2023
## [1.11.5](bubkoo/html-to-image@v1.11.4...v1.11.5) (2023-01-30)

### Bug Fixes

* **cloneCSSStyle:** rounded values of d attr fix ([bubkoo#358](bubkoo#358)) ([6d28bdb](bubkoo@6d28bdb)), closes [bubkoo#357](bubkoo#357)
* include source in npm package ([bubkoo#316](bubkoo#316)) ([b609415](bubkoo@b609415))
* switch lazy loading images to eager ([bubkoo#359](bubkoo#359)) ([f7c311b](bubkoo@f7c311b))
istaiti pushed a commit to inscreen/html-to-image that referenced this pull request Feb 7, 2023
istaiti pushed a commit to inscreen/html-to-image that referenced this pull request Feb 7, 2023
## [1.11.5](bubkoo/html-to-image@v1.11.4...v1.11.5) (2023-01-30)

### Bug Fixes

* **cloneCSSStyle:** rounded values of d attr fix ([bubkoo#358](bubkoo#358)) ([6d28bdb](bubkoo@6d28bdb)), closes [bubkoo#357](bubkoo#357)
* include source in npm package ([bubkoo#316](bubkoo#316)) ([b609415](bubkoo@b609415))
* switch lazy loading images to eager ([bubkoo#359](bubkoo#359)) ([f7c311b](bubkoo@f7c311b))
istaiti pushed a commit to inscreen/html-to-image that referenced this pull request Feb 7, 2023
istaiti pushed a commit to inscreen/html-to-image that referenced this pull request Feb 7, 2023
## [1.11.5](bubkoo/html-to-image@v1.11.4...v1.11.5) (2023-01-30)

### Bug Fixes

* **cloneCSSStyle:** rounded values of d attr fix ([bubkoo#358](bubkoo#358)) ([6d28bdb](bubkoo@6d28bdb)), closes [bubkoo#357](bubkoo#357)
* include source in npm package ([bubkoo#316](bubkoo#316)) ([b609415](bubkoo@b609415))
* switch lazy loading images to eager ([bubkoo#359](bubkoo#359)) ([f7c311b](bubkoo@f7c311b))
istaiti pushed a commit to inscreen/html-to-image that referenced this pull request Feb 7, 2023
istaiti pushed a commit to inscreen/html-to-image that referenced this pull request Feb 7, 2023
## [1.11.5](bubkoo/html-to-image@v1.11.4...v1.11.5) (2023-01-30)

### Bug Fixes

* **cloneCSSStyle:** rounded values of d attr fix ([bubkoo#358](bubkoo#358)) ([6d28bdb](bubkoo@6d28bdb)), closes [bubkoo#357](bubkoo#357)
* include source in npm package ([bubkoo#316](bubkoo#316)) ([b609415](bubkoo@b609415))
* switch lazy loading images to eager ([bubkoo#359](bubkoo#359)) ([f7c311b](bubkoo@f7c311b))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants