New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

why add this breaking chang in this version #365

Closed

mochen666 opened this issue Jan 31, 2023 · 13 comments

Assignees

Labels

bug

mochen666 commented Jan 31, 2023

mochen666 added the bug label

Contributor

biiibooo bot commented Jan 31, 2023

👋 @mochen666

Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you include steps to reproduce it.
To help make it easier for us to investigate your issue, please follow the contributing guidelines.

We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.

Owner

bubkoo commented Jan 31, 2023 •

edited

Loading

@mochen666 Why it's a breaking change?

TouqeerH commented Jan 31, 2023 •

edited

Loading

@mochen666 Why it's a breaking change?

This change is breaking yarn. As it requires pnpm which many of us do not use.

preinstall runs wheneveryarn or npm i is executed. This requires any project that uses this library to have pnpm installed.

Fawwad-Khan commented Jan 31, 2023

Also facing the same issue.

txemaleon commented Jan 31, 2023

Hi!

Also facing this

The problem is your pre-install hook is running npx only-allow pnpm which breaks installs on packages dependant on html-to-image.

While I understand this is good intentioned, I'd appreciate if you could revert the change in the pre-install hook, as it is not needed after publishing the package and it's effectively prohibiting the installation in every non-pnpm environment.

Thanks! Hope this helps you

thealonekhan commented Jan 31, 2023

Facing same issue

carlosg-ordering commented Jan 31, 2023 •

edited

Loading

Same issue here

chrislondon commented Jan 31, 2023

same here

1 similar comment

ddelpiano commented Jan 31, 2023

same here

bubkoo added a commit that referenced this issue


          fix: revert the change in the pre-install hook

ed7db4d

do not force using pnpm

re #365

github-actions bot pushed a commit that referenced this issue


          chore(release): v1.11.10 [skip ci]

c1e4047

## [1.11.10](v1.11.9...v1.11.10) (2023-02-01)

### Bug Fixes

* revert the change in the pre-install hook ([ed7db4d](ed7db4d)), closes [#365](#365)

sandi-buchanan commented Feb 1, 2023 •

edited

Loading

Same issue being encountered in our project with version 1.11.9.

txemaleon commented Feb 1, 2023

If anyone gets here trough google, you have to update to v1.11.10 at least to fix this problema

Owner

bubkoo commented Feb 2, 2023

v1.11.9 was marked as deprecated.

bubkoo self-assigned this

istaiti pushed a commit to inscreen/html-to-image that referenced this issue


          fix: revert the change in the pre-install hook

b69811d

do not force using pnpm

re bubkoo#365

istaiti pushed a commit to inscreen/html-to-image that referenced this issue


          chore(release): v1.11.10 [skip ci]

23b6ea1

## [1.11.10](bubkoo/html-to-image@v1.11.9...v1.11.10) (2023-02-01)

### Bug Fixes

* revert the change in the pre-install hook ([ed7db4d](bubkoo@ed7db4d)), closes [bubkoo#365](bubkoo#365)

istaiti pushed a commit to inscreen/html-to-image that referenced this issue


          fix: revert the change in the pre-install hook

c2c21be

do not force using pnpm

re bubkoo#365

istaiti pushed a commit to inscreen/html-to-image that referenced this issue


          chore(release): v1.11.10 [skip ci]

8c73a97

## [1.11.10](bubkoo/html-to-image@v1.11.9...v1.11.10) (2023-02-01)

### Bug Fixes

* revert the change in the pre-install hook ([ed7db4d](bubkoo@ed7db4d)), closes [bubkoo#365](bubkoo#365)

istaiti pushed a commit to inscreen/html-to-image that referenced this issue


          fix: revert the change in the pre-install hook

a2199d1

do not force using pnpm

re bubkoo#365

istaiti pushed a commit to inscreen/html-to-image that referenced this issue


          chore(release): v1.11.10 [skip ci]

43f9262

## [1.11.10](bubkoo/html-to-image@v1.11.9...v1.11.10) (2023-02-01)

### Bug Fixes

* revert the change in the pre-install hook ([ed7db4d](bubkoo@ed7db4d)), closes [bubkoo#365](bubkoo#365)

istaiti pushed a commit to inscreen/html-to-image that referenced this issue


          fix: revert the change in the pre-install hook

d4d63af

do not force using pnpm

re bubkoo#365

istaiti pushed a commit to inscreen/html-to-image that referenced this issue


          chore(release): v1.11.10 [skip ci]

813996c

## [1.11.10](bubkoo/html-to-image@v1.11.9...v1.11.10) (2023-02-01)

### Bug Fixes

* revert the change in the pre-install hook ([ed7db4d](bubkoo@ed7db4d)), closes [bubkoo#365](bubkoo#365)

istaiti pushed a commit to inscreen/html-to-image that referenced this issue


          fix: revert the change in the pre-install hook

a2ed716

do not force using pnpm

re bubkoo#365

istaiti pushed a commit to inscreen/html-to-image that referenced this issue


          chore(release): v1.11.10 [skip ci]

3f3c38a

## [1.11.10](bubkoo/html-to-image@v1.11.9...v1.11.10) (2023-02-01)

### Bug Fixes

* revert the change in the pre-install hook ([ed7db4d](bubkoo@ed7db4d)), closes [bubkoo#365](bubkoo#365)

bubkoo closed this as completed

Contributor

biiibooo bot commented Feb 10, 2024

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

biiibooo bot locked as resolved and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.