Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of os-homedir dependency #207

Merged
merged 1 commit into from
Jul 4, 2019
Merged

Get rid of os-homedir dependency #207

merged 1 commit into from
Jul 4, 2019

Conversation

mourner
Copy link
Collaborator

@mourner mourner commented Jul 3, 2019 •
edited
Loading

Fixes the following warning when installing buble v0.19.8:

npm WARN deprecated os-homedir@2.0.0: This is not needed anymore. Use `require('os').homedir()` instead.

os-homedir isn't needed since Node v2.3.0.

@mourner mourner requested a review from adrianheine July 3, 2019 13:13
@nathancahill
Copy link
Collaborator

Awesome

@nathancahill nathancahill merged commit 652af0c into master Jul 4, 2019
@adrianheine adrianheine deleted the remove-os-homedir branch July 4, 2019 18:34
@Borewit Borewit mentioned this pull request Sep 6, 2019
Open
@timbomckay
Copy link

Has this fix been released?

@mourner mourner mentioned this pull request Mar 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrianheine adrianheine Awaiting requested review from adrianheine

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mourner @nathancahill @timbomckay