fix: Make JSX respect advanced white-space characters (fixes #217) #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mourner
approved these changes
Sep 25, 2019
luiscubal
pushed a commit
to jscrambler/buble
that referenced
this pull request
Nov 15, 2019
) (bublejs#218) HTML only collapses normal space, tabs and newlines. React's JSX (and Babel) traditionally also does that. Bublé, however, has until now greedily killed all types of spaces, except for which it turned into HTML-escaped entity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HTML only collapses normal space, tabs and newlines.
React's JSX (and Babel) traditionally also does that.
Bublé, however, has until now greedily killed all types of spaces,
except for
which it turned into HTML-escaped entity,which in turn breaks the text-node rendering in Mithril.js and Hyperscript.js.
(See #217 for more info)