[disk] limit the number of concurrent file removals even more on mac #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also adds a startup log line mentioning the value, to help debugging. This might avoid buchgr#554.
mostynb
force-pushed
the
reduce_mac_file_removal_semaphore
branch
from
5c27d22
to
5909df1
Compare
|
Should we move this behind a flag instead of setting this to 3000 or 5000. People with high config systems should not be limited to 3k or 5k. |
|
I think we can try this without a flag initially, and add one later if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also adds a startup log line mentioning the value, to help debugging.
This might avoid #554.