-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Azure blob storage support #560
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi- thanks for the contribution, this looks like a nice feature.
I have a bunch of minor ("nitpick") issues to fix, but I don't have an azure account to test this with- I assume that you have tested it though?
@mostynb thanks for the quick review it all does makes sense, I did test it against azure. I’ll make the changes and push a new commit next week (I’m out the rest of the week) |
5069f27
to
8aade7e
Compare
8aade7e
to
4e1cc1e
Compare
@mostynb I think I address all the comments, hope I understood all |
90b9168
to
c11b8f1
Compare
Squashed and landed with some minor formatting and documentation tweaks- thanks again! |
Cool @mostynb Thanks to you!! |
@bakjos - I'm trying to configure the latest version of bazel-remote to work with Azure, but it's not picking up my settings. It doesn't even seem like it's trying to Azure. Any suggestions? Here's my env file with all of my settings.
|
@karlhepler: I think you might need to set a tenant id also- does adding that help? |
@karlhepler As @mostynb said you need to set the tenant id, this is the one I used to test:
|
@karlhepler are you seeing in the logs something like |
Here's an example of what I'm seeing.
|
I wonder if there are cli args I need to pass. I'm just setting everything in environment variables. Hmmm... |
I'm also using the latest release. Perhaps it hasn't been released yet? https://github.com/buchgr/bazel-remote/releases/tag/v2.3.8 |
Based on the logs, looks like you're using the 2.3.8 image which doesn't contain the changes to support azure, you'll need to build the image from the latest main in order to use azure, not sure when @mostynb will have plans to publish a new version |
Oops- published a new version just now: https://github.com/buchgr/bazel-remote/releases/tag/v2.3.9 |
Thanks! Now there seems to be a new problem. This new version looks like it requires C. I was running it out of
|
That's correct, bazel-remote now has a cgo dependency for a native code zstdandard implementation (not used by default, yet). Are you building custom docker images instead of using the official ones? If so, I'm curious to know why. Either way, would you mind creating a new issue to discuss this, so we don't spam @bakjos? |
OK. Thanks! Sorry for the spam! |
This PR adds support to use Azure Blob storage as a proxy option.