Make max_size mandatory and remove default value #660
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #654 (comment)
This PR makes the
--max_size
flag required and removes the default value, making the default behaviour and configuration more predictable.@mostynb I couldn't test the
:bazel-remote-image
and itsarm64
variant on my machine, seems it finds no matching toolchain on my laptop (darwin/arm64), meaning I haven't been able to test how to pass the size flag tobazel run :bazel-remote-image
to update the README.If you tell me what's missing, I'd be happy to fix that.