feat(config,cache/s3proxy): add s3 addressing style support #662
Conversation
wuhuizuo
force-pushed
the
feature/s3-proxy-addressing-style-support
branch
from
6202029
to
8c78612
Compare
|
/reopen to rerun the golang ci lint job |
I fixed it. |
There was a problem hiding this comment.
This feature looks good to me, but I think we should use string flags instead, for improved readability.
I had to do some background reading to understand the use case. This blog post was useful, sharing it here for anyone reading through this PR later: https://aws.amazon.com/blogs/aws/amazon-s3-path-deprecation-plan-the-rest-of-the-story/
wuhuizuo
force-pushed
the
feature/s3-proxy-addressing-style-support
branch
from
c743668
to
5fbf4c4
Compare
wuhuizuo
force-pushed
the
feature/s3-proxy-addressing-style-support
branch
from
5fbf4c4
to
67dbda2
Compare
config/proxy.go
Outdated
| // also when not found the type, return "auto" type. | ||
| return valMap[typeStr] |
There was a problem hiding this comment.
I think this function should probably check if typeStr is in the map, and return an error if it isn't. And this error checking should be done in validateConfig() in config/config.go
There was a problem hiding this comment.
I think we only need to check it in validateConfig().
There was a problem hiding this comment.
Also I refactored it again.
wuhuizuo
force-pushed
the
feature/s3-proxy-addressing-style-support
branch
from
49bc4de
to
dff949c
Compare
|
Thanks for following through with these changes- I made a few minor tweaks and landed this on the master branch. |
Some S3 providers do not support auto bucket lookup type, need to set it with
pathtype ordnstype.Here I added a support to set it in
s3_proxyfiled in configuration to make it reachable.