Swap out minio for GoFakeS3 in .bazelci/system-test.sh #683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mostynb
force-pushed
the
try_another_s3_test_server
branch
5 times, most recently
from
b339cbc
to
025cd05
Compare
Let's see if this makes .bazelci/system-test.sh pass again with the tip of bazel's main branch. These tests also seem to run much faster now (~3m vs ~30min before). Relates to buchgr#672.
mostynb
force-pushed
the
try_another_s3_test_server
branch
from
025cd05
to
5aa8ae1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's see if this makes .bazelci/system-test.sh pass again with the tip of bazel's main branch.
These tests also seem to run much faster now (~3m vs ~30min before).
Relates to #672.