More informative error message in case of corrupted blob headers #759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mostynb
reviewed
Jun 17, 2024
cache/disk/disk.go
Outdated
| @@ -476,7 +476,7 @@ func (c *diskCache) availableOrTryProxy(kind cache.EntryKind, hash string, size | |||
| } | |||
|
|
|||
| if err != nil { | |||
| log.Printf("Warning: expected item to be on disk, but something happened: %v", err) | |||
| log.Printf("Warning: expected item to be on disk, but something happened when retrieving %s-%d: %v", hash, size, err) | |||
There was a problem hiding this comment.
Thanks for the contribution.
I'm happy to improve the logging here, but perhaps we can improve this a bit, eg:
- It might be worth logging
blobPathhere instead, like the log in the if case one level up. - Maybe we could also log something different in each of the cases in the if-else block immediately before this one?
There was a problem hiding this comment.
Hi! I have adjusted the error as suggested and added some additional variables that should make it easy to figure out which kind of ReadCloser is being fetched.
In the end my problem was that I was running the program with too little resources and that caused it to fail in various interesting ways. Once I gave it some more CPUs, it started running like expected. Although this particular error message was not very informative so it would be cool to make it better
Andrius-B
force-pushed
the
better-error-message-in-case-of-corrupted-headers
branch
from
27bfb8f
to
2a4cffe
Compare
Andrius-B
force-pushed
the
better-error-message-in-case-of-corrupted-headers
branch
from
2a4cffe
to
e626f66
Compare
|
Thanks for the contribution- this has landed on the master branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would love to get a more informative error message here. I keep seeing this happen but since the error does not contain the hash of the CAS item being fetched, it's very tricky to figure out what goes wrong from the access logs.
Specifically the error I'm seeing is this:
I'm hoping that with a hash to reference in the logs, I can find out what corrupts the headers