Additional parameter fix #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShuCh3n
requested review from
Rinor12010,
harli91,
vildanbina,
LucianTuriacArnia and
vegimcarkaxhija
LucianTuriacArnia
approved these changes
Jul 11, 2023
harli91
reviewed
Jul 11, 2023
| @@ -39,6 +39,8 @@ class BuckarooWallet extends PayablePaymentMethod | |||
| */ | |||
| public function createWallet() | |||
| { | |||
| $this->isDataRequest = true; | |||
There was a problem hiding this comment.
why not set this in a construct or something similar?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The node in the additional parameter is different between a transaction and a data request call. The transaction request accepts "AdditionalParameter" and the data request accepts "List". On default, the payload will generate the payload for the transaction request. Whenever you use a data request with an additional parameter please call the method "isDataRequest" on a Payload object. Also, there is a isDataRequest property added so you can change the property in the payment class itself.