fix: remove fatalError from BKTClient.shared

bucketeer-io · Jul 25, 2023 · aedde4e · aedde4e
1 parent b444efe
commit aedde4e
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/Bucketeer.xcodeproj/xcshareddata/xcschemes/Bucketeer.xcscheme b/Bucketeer.xcodeproj/xcshareddata/xcschemes/Bucketeer.xcscheme
@@ -58,6 +58,11 @@
                BlueprintName = "BucketeerTests"
                ReferencedContainer = "container:Bucketeer.xcodeproj">
             </BuildableReference>
+            <SkippedTests>
+               <Test
+                  Identifier = "BucketeerE2ETests">
+               </Test>
+            </SkippedTests>
          </TestableReference>
       </Testables>
    </TestAction>

diff --git a/Bucketeer/Sources/Public/BKTClient.swift b/Bucketeer/Sources/Public/BKTClient.swift
@@ -105,7 +105,16 @@ extension BKTClient {
     }
 
     public static var shared: BKTClient {
-        return BKTClient.default ?? { fatalError("BKTClient is already initialized. Not sure if the initial fetch has finished") }()
+        get throws {
+            guard BKTClient.default != nil else {
+                throw BKTError.illegalState(message: "BKTClient is not initialized")
+            }
+            return BKTClient.default
+            // We do not want to crash the SDK's consumer app on runtime by using fatalError().
+            // So let the app has a chance to catch this exception
+            // The same behavior with the Android SDK
+
+        }
     }
 
     public func stringVariation(featureId: String, defaultValue: String) -> String {