chore: add variation name property to BKTEvaluation #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cre8ivejp
force-pushed
the
chore-evaluation
branch
from
fd94a7b
to
acb9014
Compare
cre8ivejp
commented
Jun 29, 2023
| let reason: Reason | ||
| var variationValue: String |
There was a problem hiding this comment.
Because of unit tests, this var was mutable. I changed the tests so we can make it immutable.
| @@ -42,8 +42,9 @@ final class BucketeerE2ETests: XCTestCase { | |||
| assertEvaluation(actual: actual, expected: .init( | |||
| id: "feature-ios-e2e-string:2:bucketeer-ios-user-id-1", | |||
| featureId: FEATURE_ID_STRING, | |||
| featureVersion: 2, | |||
| featureVersion: 3, | |||
There was a problem hiding this comment.
Because I added the variation name on the console UI, it increased the feature version.
Same for the other e2e tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done.