feat: support swift package manager #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s2mr
force-pushed
the
feature/spm
branch
2 times, most recently
from
ef5917b
to
f8839e4
Compare
s2mr
changed the title
s2mr
changed the title
s2mr
changed the title
cre8ivejp
reviewed
Jun 20, 2023
| @@ -0,0 +1,3 @@ | |||
| enum Version { | |||
| static let current = "2.0.0" | |||
There was a problem hiding this comment.
I think we will need to add the comment to this line so the CI can update it automatically before releasing it.
E.g.
static let current = "2.0.0" // x-release-please-versionhttps://github.com/bucketeer-io/ios-client-sdk/blob/main/Bucketeer.podspec#L3
And then add the file path here.
https://github.com/bucketeer-io/ios-client-sdk/blob/main/.github/workflows/release.yml#L28
There was a problem hiding this comment.
Sorry, I didn't know the release flow.
Thank you, I fixed it.
cre8ivejp
reviewed
Jun 21, 2023
Package.swift
Outdated
| .library( | ||
| name: "Bucketeer", | ||
| targets: ["Bucketeer"] | ||
| ), |
There was a problem hiding this comment.
Can you fix the lint warning below?
Trailing Comma Violation: Collection literals should not have trailing commas (trailing_comma)
cre8ivejp
approved these changes
Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2