chore: add sdk_version to the network requests #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
should close #17 |
cre8ivejp
reviewed
Sep 27, 2023
| @@ -6,4 +6,7 @@ struct GetEvaluationsRequestBody: Codable { | |||
| let userEvaluationsId: String | |||
| let sourceId: SourceID | |||
| let userEvaluationCondition: UserEvaluationCondition | |||
| // noted: we didn't set the default value to prevent the warning about Decodeable will not work | |||
There was a problem hiding this comment.
For this case, it's okay to only leave this comment on the PR.
No need to comment on the code.
There was a problem hiding this comment.
sure, let me remove it
There was a problem hiding this comment.
removed in 0eb8b43
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
get_evaluationsrequestregister_eventsrequest