Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After App-manager restarted the DEC APP installation process, the DEC APP was not started #238

Closed
Tracked by #227
lizhihongTest opened this issue Apr 23, 2023 · 3 comments
Assignees
Labels
App-Manager The App Manager basic service bug Something isn't working

Comments

@lizhihongTest
Copy link
Collaborator

Describe the bug
After App-manager restarted the DEC APP installation process, the DEC APP was not started

To Reproduce

  • Install dec-app cyfs://5r4MYfFJ7ktzBzSi1sWmU7BJLgpEEdp8ukbWemsFuQc1/9tGpLNnPZPoULTFVB6tbzrLkHS564isyc54PmWuNW6DT
  • When DEC APP is downloading files, kill the app-manager process
  • When the app-manager is restarted by ood-daemon,Check the result of this app`status.

Expected behavior

  • The app-manager reinstall 9tGpLNnPZPoULTFVB6tbzrLkHS564isyc54PmWuNW6DT sucesss,but not start this DEC APP service.

System information
Nighlty : 1.1.0.753-preview
OOD System : cyfs-test-lab::PC-0005(Ubuntu22)

app-manager_261428_rCURRENT.log
app-manager_143230_rCURRENT.log

@weiqiushi
Copy link
Member

This is due to the fact that the previous developer handled the startup status repair logic in parallel with the command execution logic:

Since in the old code, the startup status repair was fast, just set to Failed, in most cases, the startup status was repaired before the first command was executed

However, in the new logic, the action indicated by the startup status will be executed again, which may be more time-consuming. If the Start command is executed in the startup state repair, this Start command will be skipped because DecApp is still in the wakeup state

@weiqiushi weiqiushi moved this to 📝Todo in CYFS-Stack & Services Apr 23, 2023
@weiqiushi weiqiushi moved this from 📝Todo to 🧪To Test in CYFS-Stack & Services Apr 24, 2023
@weiqiushi
Copy link
Member

When App Manager starts, instead of executing the corresponding repair logic directly, the corresponding command is inserted into the internal cmdlist from the front end

This will make DecApp's state repair time longer, but will not cause the state error problem caused by parallel execution of repair

weiqiushi added a commit that referenced this issue Apr 24, 2023
@lizhihongTest
Copy link
Collaborator Author

This Issue has been fixed in Nighlty 1.1.0.754

@lizhihongTest lizhihongTest moved this from 🧪To Test to ✅Done in CYFS-Stack & Services Apr 26, 2023
streetycat pushed a commit to streetycat/CYFS that referenced this issue May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
App-Manager The App Manager basic service bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

2 participants