Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gems: rename sha3 to keccak #6

Closed
wants to merge 2 commits into from
Closed

gems: rename sha3 to keccak #6

wants to merge 2 commits into from

Conversation

q9f
Copy link

@q9f q9f commented Dec 1, 2021

replaces digest-sha3 to enable support for ruby 2.3 and later

@a-mpch
Copy link
Contributor

a-mpch commented Dec 1, 2021

Hey @q9f, thanks for your contribution.
I don't get why digest-sha3 wouldn't support ruby >=2.3, could you elaborate more?

@q9f
Copy link
Author

q9f commented Dec 1, 2021 •
edited
Loading

It nails the required ruby version at ~> 2.2 and is unmaintained since 2015. See phusion/digest-sha3-ruby#10

I'm maintaining the keccak gem as dependency of the eth gem. See se3000/ruby-eth#58

@q9f
Copy link
Author

q9f commented Feb 8, 2022

I also upgraded eth to 0.5 if you still maintain this, I can submit an additional PR.

@jgmontoya
Copy link
Contributor

Updated it on #7

@jgmontoya jgmontoya closed this Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@q9f @a-mpch @jgmontoya