Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dialect] Timing dialect for automatically profiling models #372

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

[Dialect] Timing dialect for automatically profiling models #372

wants to merge 7 commits into from
+121,136 −3

Conversation

ShiHaoGao
Copy link
Contributor

No description provided.

@ShiHaoGao ShiHaoGao changed the title Timing dialect for automatically profiling models [Dialect] Timing dialect for automatically profiling models Aug 19, 2024
zhanghb97
zhanghb97 reviewed Sep 19, 2024
View reviewed changes
Copy link
Member

@zhanghb97 zhanghb97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add test for the dialect.

examples/TimingDialect/CMakeLists.txt Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove cmake components.

examples/BuddyLlama/CMakeLists.txt Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this modification.

midend/include/Dialect/Timing/TimingDialect.h
@@ -0,0 +1,28 @@
//===- BudDialect.h - Bud Dialect Definition --------------------*- C++ -*-===//
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BudDialect.h -> TraceDialect.h

midend/include/Dialect/Timing/TimingOps.td Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • time_start
  • time_end

midend/lib/Conversion/LowerTiming/LowerTimingPass.cpp Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only lowering the time_start and time_end operation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhanghb97 zhanghb97 zhanghb97 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShiHaoGao @zhanghb97