-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] new img container support PNG #380
Conversation
Because of the new dependencies and changes to the cmake file, a new version README is needed to guide users build with new container |
The build commands for the examples has not changed, but the build command for test has changed |
when i build buddy-mlir, i have to enable BUDDY_MLIR_ENABLE_DIP_LIB, otherwise, the build won't succeed. It's best to explain this in the pr. |
Thank you for your question. I have updated the PR to prevent compilation failure due to unspecified parameters |
@@ -57,5 +57,5 @@ SET_TARGET_PROPERTIES(LENET PROPERTIES LINKER_LANGUAGE C) | |||
add_executable(buddy-lenet-run buddy-lenet-main.cpp) | |||
target_link_directories(buddy-lenet-run PRIVATE ${LLVM_LIBRARY_DIR}) | |||
|
|||
set(BUDDY_LENET_LIBS LENET mlir_c_runner_utils ${OpenCV_LIBS}) | |||
set(BUDDY_LENET_LIBS LENET mlir_c_runner_utils ${OpenCV_LIBS} ${PNG_LIBRARY}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OpenCV_LIBS can remove
this->sizes[3] = this->width; | ||
this->setStrides(); | ||
size_t size = this->product(this->sizes); | ||
std::cout << "size" << size << std::endl; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cout 删除
New img container support PNG based on libpng
To compile target buddy-new-image-container-test:
$ cd buddy-mlir
$ mkdir build
$ cd build
$ cmake -G Ninja ..
-DMLIR_DIR=$PWD/../llvm/build/lib/cmake/mlir
-DLLVM_DIR=$PWD/../llvm/build/lib/cmake/llvm
-DLLVM_ENABLE_ASSERTIONS=ON
-DCMAKE_BUILD_TYPE=RELEASE
-DBUDDY_MLIR_ENABLE_DIP_LIB=ON
$ ninja