Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dialect] Trace dialect for automatically profiling models #388

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

LiuYang328
Copy link
Contributor

No description provided.

@LiuYang328 LiuYang328 changed the title Dialect] Trace dialect for automatically profiling models [Dialect] Trace dialect for automatically profiling models Sep 20, 2024
@@ -0,0 +1,28 @@
//===- TraceDialect.h - Trace Dialect Definition --------------------*- C++ -*-===//
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong format: 80-col limitation.


#include "Trace/TraceOpsDialect.h.inc"

#endif // TRACE_TRACEDIALECT_H
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add an empty line here.

//
//===----------------------------------------------------------------------===//
//
// This is the header file for the bud dialect.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bud -> trace

@@ -0,0 +1,47 @@
//===- TraceDialect.td - Trace Dialect Definition --------------*- tablegen -*-===//
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong format: 80-col limitation.

@@ -0,0 +1,40 @@
//===- TraceOps.h - Trace Dialect Ops -------------------------------*- C++
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong format.

@@ -0,0 +1,84 @@
//===- TraceDialect.cpp - Trace Dialect Definition-------------------*- C++
//-*-===//
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong format.

@@ -0,0 +1,28 @@
//===- TraceOps.cpp - Trace Dialect Ops -----------------------------*- C++
//-*-===//
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong format.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use better toolchain configuration: see here

@zhanghb97
Copy link
Member

Don't forget to add .gitignore: buddy-mlir/examples/TraceDialect

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants