Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Midend] Add simplify add-const-reshape pass #389

Merged
merged 16 commits into from
Oct 31, 2024

Conversation

effrey-liu
Copy link
Contributor

@effrey-liu effrey-liu commented Sep 21, 2024

add-const-reshape simplify:
b1ccc9bbc8e9c3411a5846b21930236c

@effrey-liu effrey-liu marked this pull request as ready for review October 30, 2024 06:27
Copy link
Member

@zhanghb97 zhanghb97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Rename the folder: LlamaOptimizations -> OpSimplification
  • Please include an example in examples/BuddyNext to demonstrate the efficiency of the pass.

@@ -0,0 +1,111 @@
#include <mlir/Dialect/Affine/IR/AffineOps.h>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the license header.


LINK_LIBS PUBLIC
BuddyUtils
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add an empty line here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't find the simplify-tosa-add-reshape here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't find the simplify-tosa-add-reshape here.

@@ -0,0 +1,131 @@
//====- AddConstReshape2Const.cpp----------------------------===//
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the 80-character rule for the header; other file can be referenced.

@zhanghb97 zhanghb97 changed the base branch from main to OSPP24-Simplify October 31, 2024 07:44
@zhanghb97 zhanghb97 merged commit b1255b9 into buddy-compiler:OSPP24-Simplify Oct 31, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants