Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Infer operation data type based on its params for Corr2D #63

Merged
merged 16 commits into from
Aug 8, 2022
Merged

Infer operation data type based on its params for Corr2D #63

merged 16 commits into from
Aug 8, 2022

Commits on Aug 1, 2022

  1. Add lit-test for correlation2D

    @ArtemSkrebkov
    ArtemSkrebkov committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    4772d45 View commit details
    Browse the repository at this point in the history

  2. Add correlation i32 test

    @ArtemSkrebkov
    ArtemSkrebkov committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    5755585 View commit details
    Browse the repository at this point in the history

  3. Add support for i32 correlation 2d

    @ArtemSkrebkov
    ArtemSkrebkov committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    6260cb9 View commit details
    Browse the repository at this point in the history

  4. Enable default attribute printing for DIP

    @ArtemSkrebkov
    ArtemSkrebkov committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    6be32d5 View commit details
    Browse the repository at this point in the history

  5. Add a check for compatbility return type

    @ArtemSkrebkov
    ArtemSkrebkov committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    5ed0fb8 View commit details
    Browse the repository at this point in the history

  6. Update lit test to find mlir cpu utils

    @ArtemSkrebkov
    ArtemSkrebkov committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    3fc4bf2 View commit details
    Browse the repository at this point in the history

  7. Make output to be param for Corr2d 

      - having it as a return value causes to segfault correlation2D sample
    - it is not clear how to return MemRef from C-interface
    @ArtemSkrebkov
    ArtemSkrebkov committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    12bbcb1 View commit details
    Browse the repository at this point in the history

  8. Mark attributes with <> in dip.mlir

    @ArtemSkrebkov
    ArtemSkrebkov committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    815bfb9 View commit details
    Browse the repository at this point in the history

  9. Add a operand type check for Corr2D op and a test 

      - Make sure that input, kernel, output and constant have the same
    value and use as inferred type
  - Adding a negative lit test to check params of the op
    @ArtemSkrebkov
    ArtemSkrebkov committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    566afc8 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2022

  1. Fix review comments

    @ArtemSkrebkov
    ArtemSkrebkov committed Aug 2, 2022
    Configuration menu
    Copy the full SHA
    d64296f View commit details
    Browse the repository at this point in the history

  2. Add support for i8,i64,f64

    @ArtemSkrebkov
    ArtemSkrebkov committed Aug 2, 2022
    Configuration menu
    Copy the full SHA
    415c097 View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2022

  1. Fix correlation2D_f64 test 

     * by constructing F64 correctly
    @ArtemSkrebkov
    ArtemSkrebkov committed Aug 3, 2022
    Configuration menu
    Copy the full SHA
    1577f22 View commit details
    Browse the repository at this point in the history

  2. Fix review comment and formatting issues

    @ArtemSkrebkov
    ArtemSkrebkov committed Aug 3, 2022
    Configuration menu
    Copy the full SHA
    7d7a8db View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2022

  1. Fix more review comment 

      - extend correlation2d_invalid_type test to cover a condition for supported types
  - add comments for utility functions
    @ArtemSkrebkov
    ArtemSkrebkov committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    8d556be View commit details
    Browse the repository at this point in the history

  2. Remove insertZeroConstantOp from LowerDIPPass 

      - it is present in DIPItility.h
    @ArtemSkrebkov
    ArtemSkrebkov committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    b143870 View commit details
    Browse the repository at this point in the history

  3. Trivial changes

    @meshtag
    meshtag committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    b3dfbb5 View commit details
    Browse the repository at this point in the history