Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buf breaking fails for annotated tags with v1.35.0 #3197

Closed
paul-kinexon opened this issue Jul 30, 2024 · 4 comments · Fixed by #3198
Closed

buf breaking fails for annotated tags with v1.35.0 #3197

paul-kinexon opened this issue Jul 30, 2024 · 4 comments · Fixed by #3198
Assignees
Labels
Bug Something isn't working

Comments

@paul-kinexon
Copy link

paul-kinexon commented Jul 30, 2024

GitHub Repository

https://github.com/bufbuild/buf

Commands

git clone https://github.com/bufbuild/buf.git && cd buf
go install github.com/bufbuild/buf/cmd/buf@v1.35.1
buf breaking -v proto --against ".git#tag=v1.9.0,subdir=proto"

Output

Failure: could not clone file:///tmp/buf/.git: exit status 1
error: cannot update ref 'refs/heads/v1.9.0': trying to write non-commit object 06004969e95b09af662b3ca1b16478c1f1328591 to branch 'refs/heads/v1.9.0'
From file:///tmp/buf/
 ! [new tag]         v1.9.0     -> v1.9.0  (unable to update local ref)
 * [new tag]         v1.9.0     -> v1.9.0

Expected Output

nothing - return code 0

Anything else?

it is still working with v1.35.0, the bug was probably introduced with #3095

@paul-kinexon paul-kinexon added the Bug Something isn't working label Jul 30, 2024
@emcfarlane
Copy link
Contributor

Hi @paul-kinexon thanks for the issue, having a look now.

@doriable
Copy link
Member

doriable commented Aug 1, 2024

Thank you for the quick fix, @emcfarlane, this will go out with the next release!

@paul-kinexon
Copy link
Author

paul-kinexon commented Aug 6, 2024

Thanks for fixing this so quickly!
I just noticed that the fix is not released yet, is there a timeline for this?

@emcfarlane
Copy link
Contributor

Will go out hopefully today or tomorrow, theres some larger changes in the CHANGELOG.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants