Fix git ref to allow branches and tags #3095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the git ref input to align with the git notion of a ref as a tag or branch. We now always try to fetch a given ref before falling back to fetching the HEAD to resolve partial refs. If both a ref and branch are provided, the branch is fetched directly before resolving the ref. For example: - Branch ref=main will fetch and checkout the main branch - Tag ref=tag will fetch and checkout the tag - Partial ref=123456 will fetch HEAD and checkout 123456 - Branch with partial ref=123456,branch=feature will fetch feature and checkout 123456
emcfarlane
commented
Jun 18, 2024
bufdev
approved these changes
Jun 20, 2024
|
We cannot currently merge this since it breaks the behaviour for #419 -- we'll need to investigate a solution that continues to work with that. |
|
The latest Buf updates on your PR.
|
doriable
approved these changes
Jul 22, 2024
doriable
approved these changes
Jul 23, 2024
1 task
|
@marcus-griep-simplisafe updated in the other issue. Working on a fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the git ref input to align with the git notion of a ref as a tag or branch. We now always try to fetch a given ref before falling back to fetching the HEAD to resolve partial refs. If both a ref and branch are provided, the branch is fetched directly before resolving the ref. The inputs
tagandcommitcan still be used but can now be replaced by setting theref.For example:
ref=mainwill fetch and checkout themainbranchref=v1.0.0will fetch and checkout thev1.0.0tagref=123456will fetchHEADand checkout123456ref=123456,branch=featurewill fetchfeatureand checkout123456ref=<sha>will fetch<sha>and checkout<sha>ref=<sha>,branch=featurewith fetchfeatureand checkout<sha>Fixes #2932