Fix comment ignore with trailing comment not recognized #3295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
bufdev
reviewed
Sep 6, 2024
private/bufpkg/bufcheck/client.go
Outdated
| // | ||
| // Invalid: | ||
| // // buf:lint:ignore SERVICE_SUFFIX, SERVICE_PASCAL_CASE | ||
| // // buf:lint:ignore SERVICE_PASCAL_CASE, SERVICE_SUFFIX |
There was a problem hiding this comment.
Is this saying that you can do comma-separated ignores? I don't think that's in scope
There was a problem hiding this comment.
Updated comment in f516a9c (it also said ignoring SERVICE_PASCAL_CASE and this rule only on top)
bufdev
approved these changes
Sep 6, 2024
bufdev
reviewed
Sep 6, 2024
CHANGELOG.md
Outdated
| @@ -2,7 +2,8 @@ | |||
|
|
|||
| ## [Unreleased] | |||
|
|
|||
| - No changes yet. | |||
| - Fix issue with `buf lint` where comment ignores in the shape of `// buf:lint:ignore <RULE_ID> <extra comment>` | |||
| are not recognized due to the extra comment. | |||
There was a problem hiding this comment.
were not recognized not are not recognized
bufdev
approved these changes
Sep 6, 2024
oliversun9
deleted the
osun/allow-comment-ignore-with-trailing-comment
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the problem where comment ignores with a trailing comment is not recognized as a comment ignore: