Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade quic-go and enable HTTP/3 support for gRPC in buf curl #3305

Merged
merged 2 commits into from
Sep 10, 2024

Conversation

sudorandom
Copy link
Contributor

@sudorandom sudorandom commented Sep 9, 2024

Upgrades quic-go in order to get trailer support with HTTP/3. This allows me to remove the check preventing using --http3 and --protocol=grpc

Before:

buf curl --http3 --protocol=grpc \
    --data '{"sentence": "no"}' \
    https://demo.connectrpc.com/connectrpc.eliza.v1.ElizaService/Say

{
   "code": "internal",
   "message": "protocol error: no Grpc-Status trailer: unexpected EOF"
}

After:

buf curl --http3 --protocol=grpc \
    --data '{"sentence": "no"}' \
    https://demo.connectrpc.com/connectrpc.eliza.v1.ElizaService/Say

{
  "sentence": "How does that make you feel?"
}

@bufdev bufdev changed the title feat: upgrade quic-go; enable HTTP/3 support for gRPC in 'buf curl' Upgrade quic-go and enable HTTP/3 support for gRPC in buf curl Sep 9, 2024
Copy link
Member

@bufdev bufdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sudorandom for some reason, some CI jobs didn't run, can you verify make passes locally? Nothing here suggests otherwise but wanted to check.

@sudorandom
Copy link
Contributor Author

@bufdev go mod tidy -v apparently had the smallest of diffs (a white space change at the end). I checked the change in, and now make finishes correctly for me. Hopefully the CI should work as well.

@bufdev bufdev merged commit 7757cbc into bufbuild:main Sep 10, 2024
3 checks passed
@sudorandom sudorandom deleted the grpc-http3 branch September 10, 2024 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants