Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust end line and column expectations in lint and breaking tests #3319

Merged
merged 3 commits into from
Sep 13, 2024

Conversation

oliversun9
Copy link
Contributor

This fixes the issue where in buf_lint/breaking.test, file annotations' end lines and columns are not compared. This also corrects some test expectations for end lines and columns.

Copy link
Contributor

The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedSep 13, 2024, 9:17 PM

@oliversun9 oliversun9 merged commit 6df73b9 into main Sep 13, 2024
13 checks passed
@oliversun9 oliversun9 deleted the osun/adjust-location-expectations branch September 13, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants