Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable plugins by default remove BUF_BETA_PLUGINS_ENABLED #3326

Merged
merged 4 commits into from
Sep 18, 2024

Conversation

emcfarlane
Copy link
Contributor

Completes the TODOs enabling plugins by default. Reverts #3288

Completes the TODOs enabling plugins by default.
Copy link
Contributor

github-actions bot commented Sep 16, 2024

The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedSep 18, 2024, 8:53 PM

@bufdev
Copy link
Member

bufdev commented Sep 16, 2024

This is good to go but wait until all docs are ready before merging. I also want to put a changelog entry on this for the plugins, but will do that later.

@emcfarlane emcfarlane marked this pull request as draft September 16, 2024 22:10
@bufdev bufdev marked this pull request as ready for review September 18, 2024 20:53
Copy link
Member

@bufdev bufdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will merge when this is ready, thanks!

@bufdev bufdev merged commit 82e9594 into main Sep 18, 2024
11 checks passed
@bufdev bufdev deleted the ed/enablePluginsByDefault branch September 18, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants