Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WKT resolver for bufcurl #3333

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Add WKT resolver for bufcurl #3333

merged 1 commit into from
Sep 23, 2024

Conversation

emcfarlane
Copy link
Contributor

@emcfarlane emcfarlane commented Sep 20, 2024

Appends a WKT resolver, by default, to the list of provided schemas. This WKT resolver is needed on request or responses that include a google.protobuf.Any that contains a WKT when marshalling to and form JSON (for displaying to the user).

Tested on a custom server. Resolvers are used starting from the reflection service, next schemas, then finally WKT image. This allows overriding the WKT if a schema is provided that includes them.

Copy link
Contributor

The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedSep 20, 2024, 3:09 PM

@emcfarlane emcfarlane marked this pull request as ready for review September 20, 2024 16:57
@emcfarlane emcfarlane merged commit 1e73ead into main Sep 23, 2024
15 checks passed
@emcfarlane emcfarlane deleted the ed/curlWKT branch September 23, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants