Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify our exports with arethetypeswrong #16

Closed
timostamm opened this issue Sep 29, 2023 · 0 comments · Fixed by #27
Closed

Verify our exports with arethetypeswrong #16

timostamm opened this issue Sep 29, 2023 · 0 comments · Fixed by #27
Assignees
@smaye81

Comments

@timostamm
Copy link
Member

https://arethetypeswrong.github.io/ verifies type exports of NPM packages with the version resolution algorithms implemented in TypeScript.

It's available as a CLI, and we should use it here to guard against regressions. For reference, see connectrpc/connect-es#838.
@smaye81 smaye81 mentioned this issue Oct 2, 2023
Merged
smaye81 added a commit that referenced this issue Oct 2, 2023
@smaye81
Integrate arethetypeswrong (#27)
03d84ce 
Fixes #16 

This integrates the `arethetypeswrong` CLI into the repo and runs it in
CI.

As part of this change, we are also no longer publishing ESM artifacts
due to issues with default exports and transpiling from ESM code to CJS.
This should be acceptable as even `jest-environment-jsdom` does not
publish ESM.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smaye81 smaye81

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Integrate arethetypeswrong bufbuild/jest-environment-jsdom
2 participants
@smaye81 @timostamm