Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix exports; Add attw to CI #160

Merged
merged 5 commits into from
Oct 5, 2023
Merged

Fix exports; Add attw to CI #160

merged 5 commits into from
Oct 5, 2023

Conversation

srikrsna-buf
Copy link
Member

@srikrsna-buf srikrsna-buf commented Oct 5, 2023 •
edited
Loading

Fix exports according to attw. Also add attw to CI. The fix is identical to connectrpc/connect-es#838. The only difference is the use of type in package.json. This is required for jest to load modules.

@srikrsna-buf srikrsna-buf requested review from smaye81 and jhump October 5, 2023 08:24
@srikrsna-buf srikrsna-buf marked this pull request as draft October 5, 2023 08:35
@srikrsna-buf srikrsna-buf marked this pull request as ready for review October 5, 2023 08:59
jhump
jhump reviewed Oct 5, 2023
View reviewed changes
Copy link
Member

@jhump jhump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, but holding on off on approving because I feel like @smaye81 should probably take a pass and be the approver.

@srikrsna-buf srikrsna-buf merged commit bb70049 into main Oct 5, 2023
5 checks passed
@srikrsna-buf srikrsna-buf deleted the sk/attw branch October 5, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhump jhump jhump left review comments

@smaye81 smaye81 smaye81 approved these changes

@paul-sachs paul-sachs Awaiting requested review from paul-sachs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@srikrsna-buf @smaye81 @jhump