Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Timo Stamm <ts@timostamm.de>
  • Loading branch information
srikrsna-buf and timostamm committed May 9, 2024
1 parent 51669ff commit 0d0afc0
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions packages/protoc-gen-es/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -95,10 +95,9 @@ bundler configurations. If you prefer to generate TypeScript, use `target=ts`.

By default, [protoc-gen-es](https://www.npmjs.com/package/@bufbuild/protoc-gen-es)
(and all other plugins based on [@bufbuild/protoplugin](https://www.npmjs.com/package/@bufbuild/protoplugin))
don't use a file extensions in import paths.
does not add a file extensions to import paths.

Some bundlers and environments may require an import extension like [ECMAScript modules in Node.js](https://www.typescriptlang.org/docs/handbook/esm-node.html)
requires `.js` extension, and Deno requires `.ts`. With this plugin option, you can add `.js`/`.ts` extensions
Some environments require an import extension. For example, using [ECMAScript modules in Node.js](https://www.typescriptlang.org/docs/handbook/esm-node.html) requires the `.js` extension, and Deno requires `.ts`. With this plugin option, you can add `.js`/`.ts` extensions
in import paths with the given value. For example, set

- `import_extension=.js` to add the `.js` extension.
Expand Down

0 comments on commit 0d0afc0

Please sign in to comment.