V2: Add $typeName first (#923)

package.json

@@ -16,8 +16,6 @@
   ],
   "scripts": {
     "clean": "git clean -Xdf",
-    "bundle-size": "turbo run report -F ./packages/bundle-size",
-    "perf": "turbo run perf -F ./packages/protobuf-test",
     "all": "turbo run build generate test lint attw bundle-size format license-header bootstrap:inject bootstrap:wkt",
     "setversion": "node scripts/set-workspace-version.js && npm run all",
     "release": "npm run all && node scripts/release.js",

packages/bundle-size/README.md

@@ -10,23 +10,23 @@ usually do. We repeat this for an increasing number of files.
 
 ![chart](./chart.svg)
 
-<details><summary>Tabular data< /summary>
+<details><summary>Tabular data</summary>
 
-<!--- TABLE-START -->
+<!-- TABLE-START -->
 
 | code generator      | files | bundle size |  minified | compressed |
-| ------------------- | ----- | ----------: | --------: | ---------: |
-| protobuf-es         | 1     |   125,817 b |  65,597 b |   15,272 b |
-| protobuf-es         | 4     |   128,006 b |  67,105 b |   15,919 b |
-| protobuf-es         | 8     |   130,768 b |  68,876 b |   16,418 b |
-| protobuf-es         | 16    |   141,218 b |  76,857 b |   18,753 b |
-| protobuf-es         | 32    |   169,009 b |  98,875 b |   24,198 b |
-| protobuf-javascript | 1     |   339,613 b | 255,820 b |   42,481 b |
-| protobuf-javascript | 4     |   366,281 b | 271,092 b |   43,912 b |
-| protobuf-javascript | 8     |   388,324 b | 283,409 b |   45,038 b |
-| protobuf-javascript | 16    |   548,365 b | 378,100 b |   52,204 b |
-| protobuf-javascript | 32    | 1,240,889 b | 819,610 b |   78,780 b |
-
-<!--- TABLE-END -->
+| ------------------- | ----: | ----------: | --------: | ---------: |
+| protobuf-es         |     1 |   125,855 b |  65,617 b |   15,259 b |
+| protobuf-es         |     4 |   128,044 b |  67,125 b |   15,961 b |
+| protobuf-es         |     8 |   130,806 b |  68,896 b |   16,468 b |
+| protobuf-es         |    16 |   141,256 b |  76,877 b |   18,761 b |
+| protobuf-es         |    32 |   169,047 b |  98,895 b |   24,249 b |
+| protobuf-javascript |     1 |   334,193 b | 255,820 b |   42,481 b |
+| protobuf-javascript |     4 |   360,861 b | 271,092 b |   43,912 b |
+| protobuf-javascript |     8 |   382,904 b | 283,409 b |   45,038 b |
+| protobuf-javascript |    16 |   542,945 b | 378,100 b |   52,204 b |
+| protobuf-javascript |    32 | 1,235,469 b | 819,610 b |   78,780 b |
+
+<!-- TABLE-END -->
 
 </details>

packages/bundle-size/package.json

@@ -2,7 +2,7 @@
   "name": "@bufbuild/bundle-size",
   "private": true,
   "scripts": {
-    "report": "tsx src/report.ts",
+    "bundle-size": "tsx src/report.ts",
     "pregenerate": "rm -rf src/gen",
     "generate": "buf generate buf.build/googleapis/googleapis:9475e2896f8a46d09806149f9382e538",
     "postgenerate": "license-header .",

packages/protobuf/src/create.ts

@@ -200,7 +200,9 @@ const messagePrototypes = new WeakMap<
 function createZeroMessage(desc: DescMessage): Message {
   let msg: Record<string, unknown>;
   if (!needsPrototypeChain(desc)) {
-    msg = {};
+    msg = {
+      $typeName: desc.typeName,
+    };
     for (const member of desc.members) {
       if (member.kind == "oneof" || member.presence == IMPLICIT) {
         msg[member.localName] = createZeroField(member);
@@ -238,6 +240,7 @@ function createZeroMessage(desc: DescMessage): Message {
       messagePrototypes.set(desc, { prototype, members });
     }
     msg = Object.create(prototype) as Record<string, unknown>;
+    msg.$typeName = desc.typeName;
     for (const member of desc.members) {
       if (members.has(member)) {
         continue;
@@ -255,7 +258,6 @@ function createZeroMessage(desc: DescMessage): Message {
       msg[member.localName] = createZeroField(member);
     }
   }
-  msg.$typeName = desc.typeName;
   return msg as Message;
 }